From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: xfstests and linux nfs testing Date: Thu, 9 Oct 2014 09:21:27 -0700 Message-ID: <20141009162127.GA12500@infradead.org> References: <54368292.8060209@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Steve French , "linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-fsdevel , fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lukas Czerner To: Anna Schumaker Return-path: Content-Disposition: inline In-Reply-To: <54368292.8060209-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Oct 09, 2014 at 08:41:54AM -0400, Anna Schumaker wrote: > I think this is a bug in xfstests. This fixes it for me, but I'm not sure what needs to be checked in the NFS case: Lukas broke this with: common: Check fs consistency on TEST_DEV only when needed as far as I can tell it blindly copied the _require_scratch code to _require_test, which is bad for two reasons: a) due to lots of code duplication b) because it broke filesystems that don't support a scratch dev like nfs. Anna fix should work, can you resend it to the fstests lists with a proper signoff? Even better would be some validation that the passed in "device" is a valid format for a nfs export, but that's not strictly required. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html