* Re: [PATCH 4/4] ext4: Add fdatasync scalability optimization
[not found] ` <87oateq4e5.fsf@openvz.org>
@ 2014-10-14 11:35 ` Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2014-10-14 11:35 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-kernel, linux-ext4, linux-fsdevel
On Tue, Oct 14, 2014 at 03:25:54PM +0400, Dmitry Monakhov wrote:
> Christoph Hellwig <hch@infradead.org> writes:
>
> > Much of the bookkeeping here seems generic and should be in common
> > code and not inside a filesystem.
> Yes. But this means that I need to store flush_id inside generic inode
> which likely will be accepted negatively because VFS people do not like
> inode bloating. But if you are OK then I'll prepare the patch.
With my "VFS person critical of struct inode size increases" hat on
I'm still critical of any struct inode increase, so if you can find
an option that say just takes the address of the counter variable
I'd prefer that. But even if we have to increase the inode this might
be one of the cases where it's fine as cache flushing is something
at least all on disk filesystems need to do.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-10-14 11:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1413281035-6483-1-git-send-email-dmonakhov@openvz.org>
[not found] ` <1413281035-6483-5-git-send-email-dmonakhov@openvz.org>
[not found] ` <20141014105729.GA19981@infradead.org>
[not found] ` <87oateq4e5.fsf@openvz.org>
2014-10-14 11:35 ` [PATCH 4/4] ext4: Add fdatasync scalability optimization Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).