From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] fallocate: create FAN_MODIFY and IN_MODIFY events
Date: Tue, 14 Oct 2014 15:43:49 -0700
Message-ID: <20141014154349.ca831a4d1e5c1747779552ec@linux-foundation.org>
References: <1412287587-5392-1-git-send-email-xypron.glpk@gmx.de>
	<1412324370-959-1-git-send-email-xypron.glpk@gmx.de>
	<20141006141227.GF7526@quack.suse.cz>
	<5432E921.7040306@gmx.de>
	<20141007180559.GC30038@quack.suse.cz>
	<54342FC2.7030509@gmx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Jan Kara <jack@suse.cz>, Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eric Paris <eparis@parisplace.org>,
	John McCutchan <john@johnmccutchan.com>,
	Robert Love <rlove@rlove.org>,
	Michael Kerrisk <mtk.manpages@gmail.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:46983 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755826AbaJNWnu (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 14 Oct 2014 18:43:50 -0400
In-Reply-To: <54342FC2.7030509@gmx.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 07 Oct 2014 20:24:02 +0200 Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> Hello Andrew,
> 
> the patch in
> https://lkml.org/lkml/2014/10/3/56
> and cited below was reviewed by Jan Kara.
> 

Jan wondered why we generate events for FALLOC_FL_KEEP_SIZE, so other
people will wonder the same thing.  We should tell them.  Via code
comments and/or changelogging.

Any question which a reviewer asks should be viewed as a defect in the
patch.  The patch isn't finished until people can read it without
having questions.