From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/4] fs: add fadvise file_operation Date: Sun, 19 Oct 2014 07:51:38 -0700 Message-ID: <20141019145138.GB9593@infradead.org> References: <1413645688-13524-1-git-send-email-dmonakhov@openvz.org> <1413645688-13524-3-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, hch@infradead.org To: Dmitry Monakhov Return-path: Content-Disposition: inline In-Reply-To: <1413645688-13524-3-git-send-email-dmonakhov@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Oct 18, 2014 at 07:21:26PM +0400, Dmitry Monakhov wrote: > sys_fadvise result in direct f_mode modification, which may be not > suitable for some unusual filesytems where file mode invariant is more > complex. In order to support such filesystems we have to delegate fadvise > logic to filesystem layer. Is there a real use case for it? So for it seems mostly about ecryptfs, and even that use is lacking a proper explanation. Also fadvice and set_flags seem entirely unrelated, I don't understand why you're throwing fadvice in thise series.