linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	"Hammond, John" <john.hammond@intel.com>
Subject: Re: [RFC] lustre treatment of dentry->d_name
Date: Tue, 21 Oct 2014 20:30:33 +0100	[thread overview]
Message-ID: <20141021193033.GS7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20141021040210.GR7996@ZenIV.linux.org.uk>

On Tue, Oct 21, 2014 at 05:02:10AM +0100, Al Viro wrote:

> Another question: what's wrong with d_splice_alias() or d_materialise_unique()?
> I.e. why do we need ll_splice_alias()?  I have patches in local queue
> (soon to show up in for-next) that merge d_splice_alias() and
> d_materialise_unique(), essentially teaching the former to deal with one
> case d_materialise_unique() can handle while d_splice_alias() couldn't.
> If you need something not covered by those, it would be interesting to
> find out if it would make sense to fold _that_ into d_splice_alias() as well...

Next one: is there any codepath that could lead to ll_md_blocking_ast()
before we get ->s_root assigned?  IOW, what's
                    inode->i_sb->s_root != NULL &&
in there about?  Pure paranoia or something more serious?  Because from the
look of the call chains leading to that, having them hit before the superblock
has been set up seems to be risky...

  parent reply	other threads:[~2014-10-21 19:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21  1:13 [RFC] lustre treatment of dentry->d_name Al Viro
2014-10-21  2:55 ` Al Viro
2014-10-21  3:55   ` Drokin, Oleg
2014-10-21  3:46 ` Drokin, Oleg
2014-10-21  4:02   ` Al Viro
2014-10-21 13:34     ` Drokin, Oleg
2014-10-21 21:17       ` Al Viro
2014-10-22  1:48         ` Drokin, Oleg
2014-10-22  2:50           ` Al Viro
2014-10-22  9:30             ` Drokin, Oleg
2014-10-21 19:30     ` Al Viro [this message]
2014-10-22  1:49       ` Drokin, Oleg
2014-10-21 20:07   ` Al Viro
2014-10-22  1:53     ` Drokin, Oleg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141021193033.GS7996@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=andreas.dilger@intel.com \
    --cc=john.hammond@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).