From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [RFC] lustre treatment of dentry->d_name
Date: Tue, 21 Oct 2014 20:30:33 +0100
Message-ID: <20141021193033.GS7996@ZenIV.linux.org.uk>
References: <20141021011346.GP7996@ZenIV.linux.org.uk>
 <BCCE2291-C6E5-4FD5-A0A8-D9B3BF5D6F8B@intel.com>
 <20141021040210.GR7996@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	"Hammond, John" <john.hammond@intel.com>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:58705 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755026AbaJUTag (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 21 Oct 2014 15:30:36 -0400
Content-Disposition: inline
In-Reply-To: <20141021040210.GR7996@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Oct 21, 2014 at 05:02:10AM +0100, Al Viro wrote:

> Another question: what's wrong with d_splice_alias() or d_materialise_unique()?
> I.e. why do we need ll_splice_alias()?  I have patches in local queue
> (soon to show up in for-next) that merge d_splice_alias() and
> d_materialise_unique(), essentially teaching the former to deal with one
> case d_materialise_unique() can handle while d_splice_alias() couldn't.
> If you need something not covered by those, it would be interesting to
> find out if it would make sense to fold _that_ into d_splice_alias() as well...

Next one: is there any codepath that could lead to ll_md_blocking_ast()
before we get ->s_root assigned?  IOW, what's
                    inode->i_sb->s_root != NULL &&
in there about?  Pure paranoia or something more serious?  Because from the
look of the call chains leading to that, having them hit before the superblock
has been set up seems to be risky...