From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: Intentionally corrupted vfat fs causing BUG
Date: Thu, 23 Oct 2014 17:55:33 +0100
Message-ID: <20141023165533.GD7996@ZenIV.linux.org.uk>
References: <8761fo7667.fsf@devron.myhome.or.jp>
 <543B8BC7.1040501@nod.at>
 <87y4sk5pul.fsf@devron.myhome.or.jp>
 <543B8FA7.9000106@nod.at>
 <87r3yc5oqt.fsf@devron.myhome.or.jp>
 <5443E87A.2060207@nod.at>
 <87oat29551.fsf@devron.myhome.or.jp>
 <20141023160106.GB7996@ZenIV.linux.org.uk>
 <20141023161606.GC7996@ZenIV.linux.org.uk>
 <877fzq91ky.fsf@devron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Richard Weinberger <richard@nod.at>,
	Sami Liedes <sami.liedes@iki.fi>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:37485 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753297AbaJWQzi (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 23 Oct 2014 12:55:38 -0400
Content-Disposition: inline
In-Reply-To: <877fzq91ky.fsf@devron.myhome.or.jp>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Oct 24, 2014 at 01:45:49AM +0900, OGAWA Hirofumi wrote:

> d_splice_alias() calls __d_find_alias() with want_discon==1, so
> __d_find_alias() doesn't return dentry, and d_splice_alias() doesn't use
> d_move() path, right?

Hmm...  Not in the current mainline (and not because of want_discon - that's
gone already).  However, with the fixes I've got in the local tree it
will both find and move it - same as d_materialise_unique() would in the
current mainline.