From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-unionfs@vger.kernel.org
Subject: Re: [GIT PULL] overlay filesystem v25
Date: Fri, 24 Oct 2014 04:24:22 +0100 [thread overview]
Message-ID: <20141024032422.GI7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20141024022055.GH7996@ZenIV.linux.org.uk>
On Fri, Oct 24, 2014 at 03:20:55AM +0100, Al Viro wrote:
> Why the hell do you hold ->i_mutex across the entire opening of underlying
> directory? All you need is to serialize one assignment; the side that loses
> the race will simply fput() what it opened...
>
> Oh, well - that goes under "weird pessimisations, easy to fix in followups"...
OK, pulled into vfs.git, followups in question added. Also there: fix for
a long-standing leak in d_splice_alias() failure exits. Guys, could you
check that current vfs.git#for-linus survives your local tests? Seems to
survive here; if I don't hear of any problems by tomorrow morning, to Linus
it goes... FWIW, for that pull request stats would be
Shortlog:
Al Viro (5):
fix inode leaks on d_splice_alias() failure exits
overlayfs: don't hold ->i_mutex over opening the real directory
overlayfs: make ovl_cache_entry->name an array instead of pointer
overlayfs: embed root into overlay_readdir_data
overlayfs: embed middle into overlay_readdir_data
Andy Whitcroft (1):
overlayfs: add statfs support
Erez Zadok (1):
overlayfs: implement show_options
Miklos Szeredi (11):
vfs: add i_op->dentry_open()
vfs: export do_splice_direct() to modules
vfs: export __inode_permission() to modules
vfs: introduce clone_private_mount()
vfs: export check_sticky()
vfs: add whiteout support
vfs: add RENAME_WHITEOUT
ext4: support RENAME_WHITEOUT
shmem: support RENAME_WHITEOUT
overlay filesystem
fs: limit filesystem stacking depth
Neil Brown (1):
overlay: overlay filesystem documentation
Diffstat:
Documentation/filesystems/Locking | 2 +
Documentation/filesystems/overlayfs.txt | 198 +++++++
Documentation/filesystems/vfs.txt | 7 +
MAINTAINERS | 7 +
fs/Kconfig | 1 +
fs/Makefile | 1 +
fs/btrfs/ioctl.c | 20 +-
fs/dcache.c | 2 +
fs/ecryptfs/main.c | 7 +
fs/ext4/namei.c | 95 +++-
fs/internal.h | 7 -
fs/namei.c | 41 +-
fs/namespace.c | 27 +
fs/open.c | 23 +-
fs/overlayfs/Kconfig | 10 +
fs/overlayfs/Makefile | 7 +
fs/overlayfs/copy_up.c | 414 ++++++++++++++
fs/overlayfs/dir.c | 921 +++++++++++++++++++++++++++++++
fs/overlayfs/inode.c | 425 ++++++++++++++
fs/overlayfs/overlayfs.h | 191 +++++++
fs/overlayfs/readdir.c | 589 ++++++++++++++++++++
fs/overlayfs/super.c | 796 ++++++++++++++++++++++++++
fs/splice.c | 1 +
include/linux/fs.h | 39 ++
include/linux/mount.h | 3 +
include/uapi/linux/fs.h | 1 +
mm/shmem.c | 36 +-
27 files changed, 3813 insertions(+), 58 deletions(-)
create mode 100644 Documentation/filesystems/overlayfs.txt
create mode 100644 fs/overlayfs/Kconfig
create mode 100644 fs/overlayfs/Makefile
create mode 100644 fs/overlayfs/copy_up.c
create mode 100644 fs/overlayfs/dir.c
create mode 100644 fs/overlayfs/inode.c
create mode 100644 fs/overlayfs/overlayfs.h
create mode 100644 fs/overlayfs/readdir.c
create mode 100644 fs/overlayfs/super.c
next prev parent reply other threads:[~2014-10-24 3:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 23:25 [GIT PULL] overlay filesystem v25 Miklos Szeredi
2014-10-24 2:20 ` Al Viro
2014-10-24 3:24 ` Al Viro [this message]
2014-10-24 7:24 ` Miklos Szeredi
2014-10-25 8:18 ` Al Viro
2014-10-25 9:53 ` Miklos Szeredi
2014-10-25 17:06 ` Al Viro
2014-10-27 8:06 ` Miklos Szeredi
2014-10-27 15:59 ` Paul E. McKenney
2014-10-27 17:28 ` Al Viro
2014-10-27 17:36 ` Paul E. McKenney
2014-10-28 1:12 ` Al Viro
2014-10-28 4:11 ` Paul E. McKenney
2014-10-28 22:55 ` Al Viro
2014-10-28 23:25 ` Paul E. McKenney
2014-10-24 7:28 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024032422.GI7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).