From: Jan Kara <jack@suse.cz>
To: Dave Chinner <david@fromorbit.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
LKML <linux-kernel@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Fengguang Wu <fengguang.wu@intel.com>,
lkp@01.org
Subject: Re: [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758 pagecache_isize_extended+0xdd/0x120()
Date: Mon, 27 Oct 2014 10:58:12 +0100 [thread overview]
Message-ID: <20141027095812.GA16093@quack.suse.cz> (raw)
In-Reply-To: <20141027010422.GA16186@dastard>
On Mon 27-10-14 12:04:22, Dave Chinner wrote:
> On Thu, Oct 16, 2014 at 01:01:27PM +0200, Jan Kara wrote:
> > From de3426d6495f4b44b14c09b7c7202e9a86d864b9 Mon Sep 17 00:00:00 2001
> > From: Jan Kara <jack@suse.cz>
> > Date: Thu, 16 Oct 2014 12:58:42 +0200
> > Subject: [PATCH] mm: Remove false WARN_ON from pagecache_isize_extended()
> >
> > The WARN_ON checking whether i_mutex is held in
> > pagecache_isize_extended() was wrong because some filesystems (e.g.
> > XFS) use different locks for serialization of truncates / writes. So
> > just remove the check.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > mm/truncate.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/mm/truncate.c b/mm/truncate.c
> > index 261eaf6e5a19..c646084e5eec 100644
> > --- a/mm/truncate.c
> > +++ b/mm/truncate.c
> > @@ -755,7 +755,6 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
> > struct page *page;
> > pgoff_t index;
> >
> > - WARN_ON(!mutex_is_locked(&inode->i_mutex));
> > WARN_ON(to > inode->i_size);
> >
> > if (from >= to || bsize == PAGE_CACHE_SIZE)
>
> Jan, Have you sent this patch upstream yet? I'm seeing it fire in
> my testing in 3.18-rc1 kernels, so I was wondering what your plans
> are for this...
I did send it but it got lost somewhere. I'll resend it.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-10-27 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 10:09 [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758 pagecache_isize_extended+0xdd/0x120() Fengguang Wu
2014-10-16 11:01 ` Jan Kara
2014-10-27 1:04 ` Dave Chinner
2014-10-27 9:58 ` Jan Kara [this message]
2014-10-27 21:05 ` Dave Chinner
2014-10-28 1:14 ` Xiong Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027095812.GA16093@quack.suse.cz \
--to=jack@suse.cz \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).