linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Eric Rannaud <e@nanocritical.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0
Date: Fri, 31 Oct 2014 01:42:20 -0700	[thread overview]
Message-ID: <20141031084220.GA29085@infradead.org> (raw)
In-Reply-To: <CALCETrUpMOX-0=7Pdv_etjzOjZVH4nrtiqCdWYqtM-ECKFrsYA@mail.gmail.com>

On Thu, Oct 30, 2014 at 05:01:30PM -0700, Andy Lutomirski wrote:
> > flink()), the mode really matters. So this idiotic glibc behavior of
> > only forwarding the third argument if O_CREAT is set seems to be a
> > bug.
> 
> We could bite the bullet and add a tmpfile syscall.   /me ducks

I've got another use case for that:  Samba.  It wants to inherit
all kinds of attributes (xattrs, modes, etc) during file creation,
and right now it's doing it in a racy way.  I've come up with a patch
to use O_TEMPFILE + flink, but it turns out that Samba may as well
be asked to create read-only files, which we can't create using
O_TMPFILE.

  parent reply	other threads:[~2014-10-31  8:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30  9:08 [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0 Eric Rannaud
2014-10-30 21:48 ` Andy Lutomirski
2014-10-30 22:48   ` Linus Torvalds
2014-10-30 22:58     ` Linus Torvalds
2014-10-31  0:01       ` Andy Lutomirski
2014-10-31  0:59         ` Linus Torvalds
2014-10-31  8:42         ` Christoph Hellwig [this message]
2014-10-31 18:44           ` Andy Lutomirski
2014-10-31 18:53             ` Linus Torvalds
2014-11-03  8:34               ` Christoph Hellwig
2014-11-03 17:05                 ` Linus Torvalds
2014-11-03 17:06                 ` Andy Lutomirski
2014-11-03 18:49                   ` Eric Rannaud
2014-11-03 19:04                     ` Linus Torvalds
2014-11-05  8:27                       ` Christoph Hellwig
2014-11-05 15:21                         ` Eric Rannaud
2014-11-05 15:32                           ` Andy Lutomirski
2014-11-05 17:10                             ` Linus Torvalds
2014-11-03 22:07                     ` Jeremy Allison
2014-11-05  8:25                       ` Christoph Hellwig
2014-10-31  0:57       ` Eric Rannaud
2014-10-31  1:04         ` Linus Torvalds
2014-10-31  2:12           ` Eric Rannaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141031084220.GA29085@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=e@nanocritical.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).