From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>, Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it
Date: Tue, 4 Nov 2014 11:01:41 +0100 [thread overview]
Message-ID: <20141104100141.GC2953@quack.suse.cz> (raw)
In-Reply-To: <20141104095258.GB17722@lst.de>
On Tue 04-11-14 10:52:58, Christoph Hellwig wrote:
> On Wed, Oct 22, 2014 at 10:14:11PM +0200, Jan Kara wrote:
> > Currently i_cdev reference to a character device isn't accounted in the
> > reference count of the character device. This then requires us to track
> > all references through a list of all inodes referencing a character
> > device which is somewhat clumsy and requires list_head in each inode in
> > the system.
> >
> > So make i_cdev a reference like any other.
>
> Looks good.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for review.
> Maybe you can rename the new variable to something like to_put also?
Yes, that's better. Done.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-11-04 10:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 20:14 [PATCH 0/4 v2] fs: Remove i_devices from struct inode Jan Kara
2014-10-22 20:14 ` [PATCH 1/4] blockdev: Don't use i_devices inode field Jan Kara
2014-11-04 9:42 ` Christoph Hellwig
2014-10-22 20:14 ` [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it Jan Kara
2014-11-04 9:52 ` Christoph Hellwig
2014-11-04 10:01 ` Jan Kara [this message]
2014-11-04 14:46 ` Al Viro
2014-11-04 15:37 ` Jan Kara
2014-11-04 15:40 ` Al Viro
2014-11-04 15:55 ` Jan Kara
2014-11-04 16:03 ` Al Viro
2014-11-05 16:54 ` Jan Kara
2014-10-22 20:14 ` [PATCH 3/4] chardev: Don't use i_devices inode field Jan Kara
2014-11-04 9:54 ` Christoph Hellwig
2014-10-22 20:14 ` [PATCH 4/4] fs: Remove i_devices list head Jan Kara
2014-11-04 9:55 ` Christoph Hellwig
2014-10-31 9:48 ` [PATCH 0/4 v2] fs: Remove i_devices from struct inode Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 10:27 [PATCH 0/4 v3] " Jan Kara
2014-11-04 10:27 ` [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104100141.GC2953@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).