From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0 Date: Wed, 5 Nov 2014 00:27:21 -0800 Message-ID: <20141105082721.GB19607@infradead.org> References: <20141031084220.GA29085@infradead.org> <20141103083447.GA8617@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Rannaud , Andy Lutomirski , Christoph Hellwig , "linux-kernel@vger.kernel.org" , Andrew Morton , Al Viro , linux-fsdevel To: Linus Torvalds Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:55649 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbaKEI1X (ORCPT ); Wed, 5 Nov 2014 03:27:23 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 03, 2014 at 11:04:27AM -0800, Linus Torvalds wrote: > Oh, so you don't actually need any file contents at all? > > If that is actually a real usage, then maybe we should just say that > "O_TMPFILE|O_RDONLY" is fine, and remove the check that it has to be > writable. Wasn't this disallowed to prevent problems on old kernels that don't use O_TMPFILE? In that case we'd ignore the flag and would just get a file handle for the directory instead.