From: Theodore Ts'o <tytso@mit.edu>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-fsdevel@vger.kernel.org, neilb@suse.de
Subject: Re: [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function
Date: Fri, 7 Nov 2014 11:20:25 -0500 [thread overview]
Message-ID: <20141107162025.GA607@thunk.org> (raw)
In-Reply-To: <yq1k3379fvj.fsf@sermon.lab.mkp.net>
On Fri, Nov 07, 2014 at 10:42:24AM -0500, Martin K. Petersen wrote:
> >>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
>
> Christoph> I'm not a fan of adding another function here and would
> Christoph> prefer a flag, but it looks correct,
>
> That was my original approach too but I didn't want to stomp over all
> the existing callers. Although there only are few.
>
> Ted: Which would you prefer?
There are *very* few users of blkdev_issue_zeroout(), and aside for a
single drbd, they are all in the block layer. It would only start
affecting ext4 when we plumb that flag through to sb_issue_zeroout
(which your patch doesn't currently do), at which point it will affect
4 call sites in ext4, and a call site in gfs2 and hpfs2.
So I'd be in favor of adding a flag to to blkdev_issue_zeroout(), and
I would have a slight preference for also modifying sb_issue_zeroout
so the flag gets plumbed all the way through to the fs-level callers.
Cheers,
- Ted
next prev parent reply other threads:[~2014-11-07 16:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 5:08 [RFC] Discard update for 3.19 Martin K. Petersen
2014-11-07 5:08 ` [PATCH 1/3] libata: Whitelist SSDs that are known to properly return zeroes after TRIM Martin K. Petersen
2014-11-07 8:24 ` Christoph Hellwig
2014-11-07 15:37 ` Martin K. Petersen
2014-12-05 16:45 ` Paolo Bonzini
2014-12-05 22:58 ` Elliott, Robert (Server Storage)
2014-12-08 15:15 ` Theodore Ts'o
2014-12-08 15:28 ` James Bottomley
2014-12-08 22:59 ` One Thousand Gnomes
2014-11-07 5:08 ` [PATCH 2/3] sd: Disable discard_zeroes_data for UNMAP Martin K. Petersen
2014-11-07 8:25 ` Christoph Hellwig
2014-11-10 23:43 ` Paolo Bonzini
2014-11-07 5:08 ` [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function Martin K. Petersen
2014-11-07 8:26 ` Christoph Hellwig
2014-11-07 15:42 ` Martin K. Petersen
2014-11-07 16:20 ` Theodore Ts'o [this message]
2014-11-07 16:27 ` Martin K. Petersen
2014-11-14 20:22 ` Martin K. Petersen
2014-11-17 18:53 ` Darrick J. Wong
2014-11-11 0:04 ` Darrick J. Wong
2014-11-11 2:33 ` Martin K. Petersen
2014-11-17 19:28 ` [PATCH] block: create ioctl to discard-or-zeroout a range of blocks Darrick J. Wong
2014-11-07 12:09 ` [RFC] Discard update for 3.19 Bernd Schubert
2014-11-07 12:11 ` Bernd Schubert
2014-11-07 15:46 ` Martin K. Petersen
2014-11-10 14:19 ` Christoph Hellwig
2014-11-12 18:40 ` Ewan Milne
2014-11-12 19:41 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107162025.GA607@thunk.org \
--to=tytso@mit.edu \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).