Re: [PATCH 3/3] fsnotify: Remove destroy_list from fsnotify_mark

[Jan Kara <jack@suse.cz>]

On Mon 10-11-14 11:30:50, Jan Kara wrote:
> On Thu 06-11-14 22:17:32, Heinrich Schuchardt wrote:
> > On 06.11.2014 14:03, Jan Kara wrote:
> > >destroy_list is used to track marks which still need waiting for srcu
> > >period end before they can be freed. However by the time mark is added
> > >to destroy_list it isn't in group's list of marks anymore and thus we
> > >can reuse fsnotify_mark->g_list for queueing into destroy_list. This
> > >saves two pointers for each fsnotify_mark.
> > 
> > With your patch the information how g_list is used is only provided
> > in the commit message (same is true for obj_list in PATCH 2/3).
> > 
> > Please, provide comments for the fields of structure fsnotify_mark
> > in include/linux/fsnotify_backend.h indicating how these fields are
> > used.
> > 
> > Especially if a field is reused for different purposes, as you now
> > suggest for g_list (and obj_list), this information is
> > indispensable.
>   Good point. I'll update the comments and resend. Thanks.
  So in the end I've updated comment just for the g_list. For obj_list I
realized that mark can still be reached and destroyed via group's list of
marks so the way I changed the code isn't safe. I'll think whether I'll
just discard the patch or fix it up.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR