From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 03/11] xfs: Remove some useless flags tests Date: Wed, 12 Nov 2014 10:26:34 +1100 Message-ID: <20141111232634.GV28565@dastard> References: <1415739865-2438-1-git-send-email-jack@suse.cz> <1415739865-2438-4-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com To: Jan Kara Return-path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:5762 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbaKKX0h (ORCPT ); Tue, 11 Nov 2014 18:26:37 -0500 Content-Disposition: inline In-Reply-To: <1415739865-2438-4-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 11, 2014 at 10:04:17PM +0100, Jan Kara wrote: > 'flags' have XFS_ALL_QUOTA_ACCT cleared immediately on function entry. > There's no point in checking these bits later in the function. Also > because we check something is going to change, we know some enforcement > bits are being added and thus there's no point in testing that later. > > Signed-off-by: Jan Kara Looks sane. I'll pick this up straight away. Cheers, Dave. -- Dave Chinner david@fromorbit.com