From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH 03/10] binfmt_elf: allow arch code to examine PT_LOPROC ... PT_HIPROC headers Date: Thu, 13 Nov 2014 01:16:19 +0100 Message-ID: <20141113001618.GC3839@linux-mips.org> References: <1410420623-11691-1-git-send-email-paul.burton@imgtec.com> <1410420623-11691-4-git-send-email-paul.burton@imgtec.com> <20141112134059.GA12619@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paul Burton , linux-mips@linux-mips.org, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Thierry Reding Return-path: Content-Disposition: inline In-Reply-To: <20141112134059.GA12619@ulmo> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 12, 2014 at 02:41:04PM +0100, Thierry Reding wrote: > Hi Ralf, > > This commit showed up in linux-next and causes a warning in linux/elf.h > because it doesn't know struct file. I've fixed it locally with this: > > --- > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 6bd15043a585..dac5caaa3509 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -4,6 +4,8 @@ > #include > #include > > +struct file; > + > #ifndef elf_read_implies_exec > /* Executables for which elf_read_implies_exec() returns TRUE will > have the READ_IMPLIES_EXEC personality flag set automatically. > --- > > Would you mind squashing that into the above commit to get rid of the > warning? To fix the warnings reported by sfr on powerpc64 this morning I moved most of the code added to into fs/binfmt_elf.c. That should also have taken care of the warnings you saw for ARM. Ralf