From: Thierry Reding <thierry.reding@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@imgtec.com>,
linux-mips@linux-mips.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] binfmt_elf: allow arch code to examine PT_LOPROC ... PT_HIPROC headers
Date: Thu, 13 Nov 2014 13:25:20 +0100 [thread overview]
Message-ID: <20141113122515.GF23422@ulmo> (raw)
In-Reply-To: <20141113001618.GC3839@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]
On Thu, Nov 13, 2014 at 01:16:19AM +0100, Ralf Baechle wrote:
> On Wed, Nov 12, 2014 at 02:41:04PM +0100, Thierry Reding wrote:
>
> > Hi Ralf,
> >
> > This commit showed up in linux-next and causes a warning in linux/elf.h
> > because it doesn't know struct file. I've fixed it locally with this:
> >
> > ---
> > diff --git a/include/linux/elf.h b/include/linux/elf.h
> > index 6bd15043a585..dac5caaa3509 100644
> > --- a/include/linux/elf.h
> > +++ b/include/linux/elf.h
> > @@ -4,6 +4,8 @@
> > #include <asm/elf.h>
> > #include <uapi/linux/elf.h>
> >
> > +struct file;
> > +
> > #ifndef elf_read_implies_exec
> > /* Executables for which elf_read_implies_exec() returns TRUE will
> > have the READ_IMPLIES_EXEC personality flag set automatically.
> > ---
> >
> > Would you mind squashing that into the above commit to get rid of the
> > warning?
>
> To fix the warnings reported by sfr on powerpc64 this morning I moved
> most of the code added to <linux/elf.h> into fs/binfmt_elf.c. That
> should also have taken care of the warnings you saw for ARM.
These changes didn't make it into today's next, but manually applying
them I can indeed verify that the build warning is gone.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-13 12:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 7:30 [PATCH 00/10] MIPS O32 new FP ABI support Paul Burton
2014-09-11 7:30 ` [PATCH 01/10] binfmt_elf: hoist ELF program header loading to a function Paul Burton
2014-09-11 7:30 ` [PATCH 02/10] binfmt_elf: load interpreter program headers earlier Paul Burton
2014-11-13 12:20 ` Thierry Reding
2014-11-13 17:29 ` Ralf Baechle
2014-09-11 7:30 ` [PATCH 03/10] binfmt_elf: allow arch code to examine PT_LOPROC ... PT_HIPROC headers Paul Burton
2014-11-12 13:41 ` Thierry Reding
2014-11-13 0:16 ` Ralf Baechle
2014-11-13 12:25 ` Thierry Reding [this message]
2014-09-11 7:30 ` [PATCH 04/10] MIPS: define bits introduced for hybrid FPRs Paul Burton
2014-09-11 7:30 ` [PATCH 05/10] MIPS: detect presence of the FRE & UFR bits Paul Burton
2014-09-11 7:30 ` [PATCH 06/10] MIPS: ensure Config5.UFE is clear on boot Paul Burton
2014-09-11 7:30 ` [PATCH 07/10] MIPS: support for hybrid FPRs Paul Burton
2014-12-23 23:21 ` Aaro Koskinen
2014-12-23 23:31 ` James Hogan
2014-12-23 23:51 ` Aaro Koskinen
2014-09-11 7:30 ` [PATCH 08/10] MIPS: ELF: add definition for the .MIPS.abiflags section Paul Burton
2014-09-11 7:30 ` [PATCH 09/10] MIPS: ELF: set FP mode according to .MIPS.abiflags Paul Burton
2014-09-11 7:30 ` [PATCH 10/10] MIPS: Kconfig option to better exercise/debug hybrid FPRs Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113122515.GF23422@ulmo \
--to=thierry.reding@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).