From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 04/56] fs: Macros to define splice file_operations Date: Thu, 13 Nov 2014 21:51:39 +0000 Message-ID: <20141113215139.GK7996@ZenIV.linux.org.uk> References: <1415913813-362-1-git-send-email-pieter@boesman.nl> <1415913813-362-5-git-send-email-pieter@boesman.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Josh Triplett , Jeff Layton , "J. Bruce Fields" , linux-fsdevel@vger.kernel.org, open list To: Pieter Smith Return-path: Content-Disposition: inline In-Reply-To: <1415913813-362-5-git-send-email-pieter@boesman.nl> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Nov 13, 2014 at 10:22:41PM +0100, Pieter Smith wrote: > Provides a CONFIG_SYSCALL_SPLICE compatible way of defining the .splice_read > and .splice_write file_operations so that they can later be compiled out when > the kernel is configured without the splice-family syscalls This (and subsequent stuff making use of that) is bloody pointless. You save 2 words per file_operations instance, at the cost of making things uglier and harder to grep. NAK.