Re: [PATCH] f2fs: add cleancache support

[Changman Lee <cm224.lee@samsung.com>]

On Fri, Nov 14, 2014 at 11:08:15AM +0800, Chao Yu wrote:
> Hi Changman,
> 
> > -----Original Message-----
> > From: Changman Lee [mailto:cm224.lee@samsung.com]
> > Sent: Thursday, November 13, 2014 1:35 PM
> > To: linux-fsdevel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> > Subject: [f2fs-dev] [PATCH] f2fs: add cleancache support
> > 
> > To use cleancache, fs must explicitly enable cleancache by calling
> > cleancache_init_fs.
> 
> Good catch!
> 
> AFAIK, cleancache will work only if we init its backend and register related ops,
> but since we merged the commit 962564604873 "staging: zcache: delete it", we
> have lost the zcache one. Is there other backends?
> 
> Regards,
> Yu
> 

Hi Yu,

AFAIK, Hypervisor like xen uses cleancache and frontswap positively.
And GCMA (Guaranteed CMA) is newly submitting, which has plan to be used
by cleancache.
I think it's not bad we prepare to accept them.

Thansk,

> > 
> > Signed-off-by: Changman Lee <cm224.lee@samsung.com>
> > ---
> >  fs/f2fs/super.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 512ffd8..2ebb960 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -24,6 +24,7 @@
> >  #include <linux/blkdev.h>
> >  #include <linux/f2fs_fs.h>
> >  #include <linux/sysfs.h>
> > +#include <linux/cleancache.h>
> > 
> >  #include "f2fs.h"
> >  #include "node.h"
> > @@ -1144,6 +1145,8 @@ try_onemore:
> >  		if (err)
> >  			goto free_kobj;
> >  	}
> > +
> > +	cleancache_init_fs(sb);
> >  	return 0;
> > 
> >  free_kobj:
> > --
> > 1.9.1
> > 
> > 
> > ------------------------------------------------------------------------------
> > Comprehensive Server Monitoring with Site24x7.
> > Monitor 10 servers for $9/Month.
> > Get alerted through email, SMS, voice calls or mobile push notifications.
> > Take corrective actions from your mobile device.
> > http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk