Linux filesystem development
 help / color / mirror / Atom feed
From: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: VFS: Parallel unmounting of filesystems produces system call error
Date: Tue, 18 Nov 2014 16:49:35 +0100	[thread overview]
Message-ID: <20141118164935.19771a88@lilie> (raw)

Hi Al,

I just ran some tests involving many parallel mount and unmount
operations. I sometimes get EINVAL and the umount program says "not
mounted". Which is definitively wrong. It feels like a race condition
somewhere in the VFS code.

I use todays master branch (commit fc14f9c1272f62c3) on s390 with 1024
DASD devices.

In fs/namespace.c, sys_umount:

> 	retval = user_path_mountpoint_at(AT_FDCWD, name, 
> lookup_flags, &path);
...
> 	retval = -EINVAL;
> 	if (path.dentry != path.mnt->mnt_root)
> 		goto dput_and_out;
This seems to be erroneously true from time to time.


The script does something equivalent to:
> for n in $DEVNODES; do
>	umount $n &
> done

Do you have any idea what's wrong?


Kind regards

Philipp

                 reply	other threads:[~2014-11-18 15:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118164935.19771a88@lilie \
    --to=phacht@linux.vnet.ibm.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox