From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time() Date: Thu, 27 Nov 2014 08:49:52 -0800 Message-ID: <20141127164952.GA1622@infradead.org> References: <1416997437-26092-1-git-send-email-tytso@mit.edu> <1416997437-26092-2-git-send-email-tytso@mit.edu> <20141126192328.GA20436@infradead.org> <20141127144116.GA14091@thunk.org> <20141127153315.GC14091@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Linux Filesystem Development List , Ext4 Developers List , Linux btrfs Developers List , XFS Developers To: Theodore Ts'o Return-path: Content-Disposition: inline In-Reply-To: <20141127153315.GC14091@thunk.org> Sender: linux-btrfs-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org I don't think this scheme works well. As mentioned earlier XFS doesn't even use vfs dirty tracking at the moment, so introducing this in a hidden way sounds like a bad idea. Probably the same for btrfs. I'd rather keep update_time as-is for now, don't add ->write_time and let btrfs and XFS figure out how to implement the semantics on their own.