From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask() Date: Thu, 4 Dec 2014 19:34:16 +0100 Message-ID: <20141204183416.GA23273@quack.suse.cz> References: <1417699659-14284-1-git-send-email-jack@suse.cz> <1417699659-14284-3-git-send-email-jack@suse.cz> <20141204143708.GM29748@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, linux-security-module@vger.kernel.org To: Al Viro Return-path: Content-Disposition: inline In-Reply-To: <20141204143708.GM29748@ZenIV.linux.org.uk> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu 04-12-14 14:37:09, Al Viro wrote: > On Thu, Dec 04, 2014 at 02:27:36PM +0100, Jan Kara wrote: > > WARN_ON in inode_set_mask() warns if we don't clear all bits we are > > setting instead of reverse - warning when caller requests setting and > > clearing of the same bit. > > WTF? 'mask' is "all bits we are asked to modify", 'flags' - "the values to > put into those bits". Have you even looked at the callers, let alone > tested it? Sorry, I misunderstood how the function is supposed to work. Discard this patch please. Honza -- Jan Kara SUSE Labs, CR