From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <jbacik@fb.com>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: make inode_sb_list_lock per sb
Date: Sat, 20 Dec 2014 10:16:37 +1100 [thread overview]
Message-ID: <20141219231637.GG15665@dastard> (raw)
In-Reply-To: <1419018033-26704-1-git-send-email-jbacik@fb.com>
On Fri, Dec 19, 2014 at 02:40:33PM -0500, Josef Bacik wrote:
> When doing fs_mark tests I was noticing other things getting starved out of
> doing operations while the fs was unmounting. This is because we protect all
> super_block's s_inodes list with a global lock, which is kind of a bummer.
> There doesn't seem to be any reason we do this so make it a per-sb lock. This
> makes sure that we don't add latency to anybody trying to add/remove inodes from
> the per sb list while somebody else is unmounting or evicting inodes. Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
I'll have a look at this on Monday, but in the mean time I proposed
this 18 months ago for different reasons, and never got back to it:
https://lkml.org/lkml/2013/7/31/15
Maybe you want to pick up someof the other sb inode list scalability
mods out of that series as well?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-12-19 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 19:40 [PATCH] vfs: make inode_sb_list_lock per sb Josef Bacik
2014-12-19 23:16 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219231637.GG15665@dastard \
--to=david@fromorbit.com \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).