From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] mnt: Fix a memory stomp in umount
Date: Fri, 2 Jan 2015 21:13:03 +0000 [thread overview]
Message-ID: <20150102211303.GU22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <87lhlkvqo1.fsf@x220.int.ebiederm.org>
On Fri, Jan 02, 2015 at 03:06:06PM -0600, Eric W. Biederman wrote:
> - It requires keeping track of the tail of the list which is half of the
> error prone complexity.
Er... In umount_tree() it comes pretty much for free, actually.
> - I have a fix for a bad interaction between MNT_LOCKED and MNT_DETACH
> where I need to leave mounts on the mount hash, until the final
> mntput. For that I need not to reuse the the mnt_hash lists.
Details, please.
next prev parent reply other threads:[~2015-01-02 21:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 16:57 [PATCH] mnt: Fix a memory stomp in umount Eric W. Biederman
[not found] ` <CA+55aFz6grtss0SXqOizXMOOF4sxT3FC4GC4NCiMF2Huy1vE4A@mail.gmail.com>
2014-12-18 18:41 ` Linus Torvalds
2014-12-18 19:24 ` Eric W. Biederman
2014-12-18 19:34 ` Linus Torvalds
2014-12-18 21:05 ` Al Viro
2014-12-18 21:18 ` Eric W. Biederman
2014-12-19 0:02 ` Al Viro
2014-12-19 0:03 ` Al Viro
2015-01-02 21:06 ` Eric W. Biederman
2015-01-02 21:13 ` Al Viro [this message]
2015-01-02 21:56 ` Eric W. Biederman
2014-12-18 20:01 ` Al Viro
2014-12-18 20:15 ` Al Viro
2014-12-18 20:40 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102211303.GU22149@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox