From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH] fs/9p: Initialize status in v9fs_file_do_lock. Date: Fri, 9 Jan 2015 15:20:51 +0200 Message-ID: <20150109132051.GB24928@node.dhcp.inet.fi> References: <1420804567-15371-1-git-send-email-dominique.martinet@cea.fr> <20150109123353.GA24928@node.dhcp.inet.fi> <20150109130723.GA3183@u-isr-ctg-01> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dominique Martinet Return-path: Received: from mta-out1.inet.fi ([62.71.2.203]:50981 "EHLO kirsi1.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756721AbbAINVQ (ORCPT ); Fri, 9 Jan 2015 08:21:16 -0500 Content-Disposition: inline In-Reply-To: <20150109130723.GA3183@u-isr-ctg-01> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 09, 2015 at 02:07:23PM +0100, Dominique Martinet wrote: > Kirill A. Shutemov wrote on Fri, Jan 09, 2015 at 02:33:53PM +0200: > > On Fri, Jan 09, 2015 at 12:56:07PM +0100, Dominique Martinet wrote: > > > If p9_client_lock_dotl returns an error, status is possibly never filled > > > but will be used in the following switch. > > > Initializing it to P9_LOCK_ERROR makes sur we will return an error and > > > cleanup (and not hit the default case). > > > > That's what my patch[1] fixes. > > > > http://marc.info/?i=1419858019-116944-1-git-send-email-kirill.shutemov%40linux.intel.com > > Actually, it's slightly different and still worth adding (mine if we > apply your's first and your's if we apply mine first - don't think > they'll conflict. I even reworded the (too old!) commit message to fit > with your patch :)) > > Your patch will not BUG() if status is junk, BUT if status uninitialized > value is 0 and p9_client_lock_dotl then we'll return res=0 (success) and > not unlock before returning. My patch makes sure we'll return -ENOLCK. No, if p9_client_lock_dotl() return 0 it must set status. If it's not, that's bug on p9_client_lock_dotl() side and must be fixed. -- Kirill A. Shutemov