From: Tejun Heo <tj@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Tim Small <tim@seoss.co.uk>,
linux-ide@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] libata: Whitelist SSDs that are known to properly return zeroes after TRIM
Date: Fri, 9 Jan 2015 16:39:29 -0500 [thread overview]
Message-ID: <20150109213929.GD2785@htj.dyndns.org> (raw)
In-Reply-To: <yq1387j1xtm.fsf@sermon.lab.mkp.net>
On Fri, Jan 09, 2015 at 03:52:21PM -0500, Martin K. Petersen wrote:
> >>>>> "Tim" == Tim Small <tim@seoss.co.uk> writes:
>
> Tim> would seem clearer to me, because as the patch currently stands,
> Tim> "ATA_HORKAGE_ZERO_AFTER_TRIM" implies to me "zero after trim is
> Tim> broken on this device".
>
> In SCSI we use often the term "quirk" regardless of whether we enable or
> disable a feature. So "horkage" didn't really bother me much in this
> context. But I'm happy to submit a name change patch if Tejun thinks
> it's a valid concern.
I think it's fine. It's not like its polarity is confusing - nobody
would read it as meaning the opposite.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-01-09 21:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yq18uiojfq9.fsf@sermon.lab.mkp.net>
[not found] ` <20141204170611.GB2995@htj.dyndns.org>
[not found] ` <yq14mtahmil.fsf@sermon.lab.mkp.net>
[not found] ` <20141205145148.GI4080@htj.dyndns.org>
[not found] ` <1418184578.2121.3.camel@HansenPartnership.com>
[not found] ` <20141210142927.GA6294@htj.dyndns.org>
[not found] ` <yq1oarbcj6f.fsf@sermon.lab.mkp.net>
[not found] ` <20150105162830.GP15833@htj.dyndns.org>
2015-01-07 0:05 ` [PATCH] libata: Whitelist SSDs that are known to properly return zeroes after TRIM Martin K. Petersen
2015-01-07 2:54 ` Tejun Heo
2015-01-07 4:15 ` Dave Chinner
2015-01-07 15:26 ` Tejun Heo
2015-01-08 14:28 ` Martin K. Petersen
2015-01-08 15:11 ` Tejun Heo
2015-01-08 15:34 ` Martin K. Petersen
2015-01-08 15:36 ` Tejun Heo
2015-01-08 15:58 ` Tim Small
2015-01-09 20:52 ` Martin K. Petersen
2015-01-09 21:39 ` Tejun Heo [this message]
2015-01-08 14:29 ` Martin K. Petersen
2015-01-08 4:05 ` Phillip Susi
2015-01-08 4:58 ` Andreas Dilger
2015-01-08 14:09 ` Phillip Susi
2015-01-08 22:31 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109213929.GD2785@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tim@seoss.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).