From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Haynes Subject: Re: [PATCH 03/18] nfsd: factor out a helper to decode nfstime4 values Date: Sun, 11 Jan 2015 18:53:44 -0500 Message-ID: <20150111235344.GA11746@slacker.internal.excfb.com> References: <1420561721-9150-1-git-send-email-hch@lst.de> <1420561721-9150-4-git-send-email-hch@lst.de> <20150109230202.GB107259@kitty> <20150111114242.GA11939@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "J. Bruce Fields" , Jeff Layton , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20150111114242.GA11939-jcswGhMUV9g@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Sun, Jan 11, 2015 at 12:42:42PM +0100, Christoph Hellwig wrote: > On Fri, Jan 09, 2015 at 03:02:02PM -0800, Tom Haynes wrote: > > > > > - READ_BUF(12); > > > len += 12; > > > > I think this code makes it clear that the magic number 12 is the > > same on both lines. With the change, that gets lost. > > > > Do I think that the 12 will ever change? No. > > > > Do I think this becomes more "magic"? Yes. > > Sure. but the whole counting the number to be decoded in setattr > is magic to start with. Agreed. > I guess we could replace it with some magic > pointer arithmetic on argp->p, but is that really worth it? Which is why I asked the leading questions. I see both sides, but ultimately it is a nit considering the rest of the abuse. I'm fine with you deciding it is still magic overall. > Should > be a separate patch for sure. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html