* [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2]
@ 2015-01-13 17:57 David Howells
2015-01-16 8:34 ` Jesper Nilsson
2015-01-19 12:06 ` David Howells
0 siblings, 2 replies; 3+ messages in thread
From: David Howells @ 2015-01-13 17:57 UTC (permalink / raw)
To: jesper.nilsson, viro
Cc: linux-fsdevel, dhowells, linux-kernel, linux-cris-kernel
Convert file->f_dentry->d_inode to file_inode() so as to get layered
filesystems right.
Found with: git grep '[.>]f_dentry'
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/cris/arch-v32/drivers/sync_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
index 08a313fc2241..f772068d9e79 100644
--- a/arch/cris/arch-v32/drivers/sync_serial.c
+++ b/arch/cris/arch-v32/drivers/sync_serial.c
@@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
struct timespec *ts)
{
unsigned long flags;
- int dev = MINOR(file->f_dentry->d_inode->i_rdev);
+ int dev = MINOR(file_inode(file)->i_rdev);
int avail;
struct sync_port *port;
unsigned char *start;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2]
2015-01-13 17:57 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2] David Howells
@ 2015-01-16 8:34 ` Jesper Nilsson
2015-01-19 12:06 ` David Howells
1 sibling, 0 replies; 3+ messages in thread
From: Jesper Nilsson @ 2015-01-16 8:34 UTC (permalink / raw)
To: David Howells
Cc: Jesper Nilsson, viro@ZenIV.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cris-kernel
On Tue, Jan 13, 2015 at 06:57:53PM +0100, David Howells wrote:
> Convert file->f_dentry->d_inode to file_inode() so as to get layered
> filesystems right.
>
> Found with: git grep '[.>]f_dentry'
Yes, compile works with this patch. Do you want me to take it through
the CRIS tree or do you have any other tree in mind?
> Signed-off-by: David Howells <dhowells@redhat.com>
In any case:
Reviewed-by: Jesper Nilsson <jesper.nilsson@axis.com>
> arch/cris/arch-v32/drivers/sync_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
> index 08a313fc2241..f772068d9e79 100644
> --- a/arch/cris/arch-v32/drivers/sync_serial.c
> +++ b/arch/cris/arch-v32/drivers/sync_serial.c
> @@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
> struct timespec *ts)
> {
> unsigned long flags;
> - int dev = MINOR(file->f_dentry->d_inode->i_rdev);
> + int dev = MINOR(file_inode(file)->i_rdev);
> int avail;
> struct sync_port *port;
> unsigned char *start;
>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2]
2015-01-13 17:57 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2] David Howells
2015-01-16 8:34 ` Jesper Nilsson
@ 2015-01-19 12:06 ` David Howells
1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2015-01-19 12:06 UTC (permalink / raw)
To: Jesper Nilsson
Cc: dhowells, Jesper Nilsson, viro@ZenIV.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cris-kernel
Jesper Nilsson <jesper.nilsson@axis.com> wrote:
> Yes, compile works with this patch. Do you want me to take it through
> the CRIS tree or do you have any other tree in mind?
I can take it.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-19 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 17:57 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2] David Howells
2015-01-16 8:34 ` Jesper Nilsson
2015-01-19 12:06 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).