From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 01/17] quota: Split ->set_xstate callback into two Date: Mon, 19 Jan 2015 01:00:35 -0800 Message-ID: <20150119090035.GA27474@infradead.org> References: <1421412471-4747-1-git-send-email-jack@suse.cz> <1421412471-4747-2-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Jan Kara Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:46951 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbbASJAg (ORCPT ); Mon, 19 Jan 2015 04:00:36 -0500 Content-Disposition: inline In-Reply-To: <1421412471-4747-2-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 16, 2015 at 01:47:35PM +0100, Jan Kara wrote: > Split ->set_xstate callback into two callbacks - one for turning quotas > on (->quota_enable) and one for turning quotas off (->quota_disable). That > way we don't have to pass quotactl command into the callback which seems > cleaner. > > Signed-off-by: Jan Kara Looks good, Reviewed-by: Christoph Hellwig