From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Date: Mon, 19 Jan 2015 01:01:21 -0800 Message-ID: <20150119090121.GB27474@infradead.org> References: <1421412471-4747-1-git-send-email-jack@suse.cz> <1421412471-4747-3-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Jan Kara Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:46969 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbbASJBV (ORCPT ); Mon, 19 Jan 2015 04:01:21 -0500 Content-Disposition: inline In-Reply-To: <1421412471-4747-3-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 16, 2015 at 01:47:36PM +0100, Jan Kara wrote: > Make Q_QUOTAON / Q_QUOTAOFF quotactl call ->quota_enable / > ->quota_disable callback when provided. To match current behavior of > ocfs2 & ext4 we make these quotactls turn on / off quota enforcement for > appropriate quota type. > > Signed-off-by: Jan Kara > --- > fs/quota/quota.c | 31 +++++++++++++++++++++++++++---- > include/linux/quotaops.h | 2 ++ > 2 files changed, 29 insertions(+), 4 deletions(-) > > diff --git a/fs/quota/quota.c b/fs/quota/quota.c > index 5b307e2b5719..748716ffee48 100644 > --- a/fs/quota/quota.c > +++ b/fs/quota/quota.c > @@ -66,18 +66,43 @@ static int quota_sync_all(int type) > return ret; > } > > +unsigned int qtype_limit_flag(int type) > +{ > + switch (type) { > + case USRQUOTA: > + return FS_QUOTA_UDQ_ENFD; > + case GRPQUOTA: > + return FS_QUOTA_GDQ_ENFD; > + case PRJQUOTA: > + return FS_QUOTA_PDQ_ENFD; > + } > + return 0; What's the limit_ in the name supposed to mean? Otherwise looks good: Reviewed-by: Christoph Hellwig