From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>
Subject: Re: [PATCH 1/4] quota: Don't store flags for v2 quota format
Date: Mon, 19 Jan 2015 01:14:32 -0800 [thread overview]
Message-ID: <20150119091432.GA15695@infradead.org> (raw)
In-Reply-To: <20150115101310.GD12739@quack.suse.cz>
On Thu, Jan 15, 2015 at 11:13:10AM +0100, Jan Kara wrote:
> Hum, I'm not sure I follow you. Current kernels will store any 32-bit
> number user sets in flags field. So if we wanted to be 100% safe, we'd have
> to just ignore that field. Which isn't currently a problem since quota code
> doesn't use the field for anything (it was added just for future
> extensions). But since I'm pretty certain noone actually relies on values
> of that field, I though we could just get away with forcibly zeroing the
> field now and if there's a need to use the field in a few years, we could
> start using it.
Oh, I misread the code and your description. I thought we would just
store any potentially valid in-core flag on disk.
I guess for now the best case would be to stop storing anything, and
then just make an educated decision if/when we need a flags field.
next prev parent reply other threads:[~2015-01-19 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 18:27 [PATCH 0/4] Quota cleanups Jan Kara
2015-01-14 18:27 ` [PATCH 1/4] quota: Don't store flags for v2 quota format Jan Kara
2015-01-15 9:40 ` Christoph Hellwig
2015-01-15 10:13 ` Jan Kara
2015-01-19 9:14 ` Christoph Hellwig [this message]
2015-01-19 12:34 ` Jan Kara
2015-01-14 18:27 ` [PATCH 2/4] ocfs2: Move OLQF_CLEAN flag out of generic quota flags Jan Kara
2015-01-14 18:27 ` [PATCH 3/4] quota: Cleanup flags definitions Jan Kara
2015-01-14 18:27 ` [PATCH 4/4] quota: Verify flags passed to Q_SETINFO Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119091432.GA15695@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).