From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 03/17] quota: Add ->quota_{enable,disable} callbacks for VFS quotas Date: Tue, 20 Jan 2015 18:08:29 +0100 Message-ID: <20150120170829.GE3648@quack.suse.cz> References: <1421412471-4747-1-git-send-email-jack@suse.cz> <1421412471-4747-4-git-send-email-jack@suse.cz> <20150119090248.GC27474@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34366 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754565AbbATRIb (ORCPT ); Tue, 20 Jan 2015 12:08:31 -0500 Content-Disposition: inline In-Reply-To: <20150119090248.GC27474@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 19-01-15 01:02:48, Christoph Hellwig wrote: > On Fri, Jan 16, 2015 at 01:47:37PM +0100, Jan Kara wrote: > > +EXPORT_SYMBOL(dquot_quota_enable); > > > +EXPORT_SYMBOL(dquot_quota_disable); > > I can't find any modular users of this (in fact none outside this > file), so I'd suggest to keep these local. OK, we can do that. I've exported the functions because in principle filesystems are free to provide own .quota_enable function and then may want to call dquot_quota_enable() from there but currently nobody needs that so let's export them only if there are real users. Honza -- Jan Kara SUSE Labs, CR