From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 12/17] xfs: Convert to using ->get_state callback Date: Tue, 20 Jan 2015 18:33:07 +0100 Message-ID: <20150120173307.GH3648@quack.suse.cz> References: <1421412471-4747-1-git-send-email-jack@suse.cz> <1421412471-4747-13-git-send-email-jack@suse.cz> <20150119093810.GA16484@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34896 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbbATRdJ (ORCPT ); Tue, 20 Jan 2015 12:33:09 -0500 Content-Disposition: inline In-Reply-To: <20150119093810.GA16484@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 19-01-15 01:38:10, Christoph Hellwig wrote: > > +static void xfs_qm_fill_state(struct qc_type_state *tstate, > > Normal xfs style would be to keep the "static void " on a separate line, > as well as the arguments, e.g. OK, will change it to conform to the XFS coding style. > static void > xfs_qm_fill_state( > struct qc_type_state *tstate, > > > > > + struct xfs_mount *mp, > > + struct xfs_inode *ip, > > + xfs_ino_t ino) > > No need to pass mp, as it can be derived as ip->i_mount. Good point. > Btw, I think this code should move into xfs_quotaops.c now > that it ties into the Linux quota interface, and xfs_qm_scall_getstate > should be folded into xfs_fs_get_quota_state. OK, will do. Honza -- Jan Kara SUSE Labs, CR