From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH RFC] fs/aio: fix sleeping while TASK_INTERRUPTIBLE Date: Wed, 21 Jan 2015 21:13:13 +1100 Message-ID: <20150121101313.GJ16510@dastard> References: <20141223001619.GA26385@ret.masoncoding.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Chris Mason , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, Peter Zijlstra Return-path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:62659 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbbAUKP1 (ORCPT ); Wed, 21 Jan 2015 05:15:27 -0500 Content-Disposition: inline In-Reply-To: <20141223001619.GA26385@ret.masoncoding.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Dec 22, 2014 at 07:16:25PM -0500, Chris Mason wrote: > The 3.19 merge window brought in a great new warning to catch someone > calling might_sleep with their state != TASK_RUNNING. The idea was to > find buggy code locking mutexes after calling prepare_to_wait(), kind > of like this: > > [ 445.464634] WARNING: CPU: 22 PID: 4367 at kernel/sched/core.c:7303 __might_sleep+0x9a/0xb0() > [ 445.481699] do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait_event+0x68/0x120 Hi Chris, This still isn't fixed in -rc5 - I'm hitting it multiple times in every xfstests run I do. What's the current status of your fix? Cheers, Dave. -- Dave Chinner david@fromorbit.com