linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Dave Chinner <david@fromorbit.com>
Cc: Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
	cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Wed, 21 Jan 2015 23:23:20 +0100	[thread overview]
Message-ID: <20150121222320.GA30154@quack.suse.cz> (raw)
In-Reply-To: <20150121213826.GL16510@dastard>

On Thu 22-01-15 08:38:26, Dave Chinner wrote:
> On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote:
> >   Hello,
> > 
> >   this is another iteration of patches to unify VFS and XFS quota interfaces so
> > that XFS quotactls work for filesystems with VFS quotas and vice versa.  This
> > is useful so that userspace doesn't have to care that much about which
> > filesystem it is using at least when using basic quota functionality. In
> > particular we should be able to reuse project quota tests in xfstests for ext4.
> > 
> > The patches are based on quota cleanup series [1] and XFS cleanup series [2]
> > I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree.  I
> > could further split this series into per-quotactl series but frankly I don't
> > think it will help reviewers in any way (the patches in the current series are
> > already ordered by quotactl).
> 
> Hi Jan,
> 
> Do you have a this series in a git tree somewhere so it's easy to
> merge and test?
  I've pushed out the series to:
git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git quota_interface

  BTW, I've already implemented suggestions by Christoph so it's not
exactly what was sent to the list (but very close). I'd also welcome your
opinion on usage of BBTOB() and BTOBB() macros in fs/quota/quota.c - to be
able to use them I have to move them out of fs/xfs/libxfs/xfs_fs.h to
somewhere in include/. Christoph doesn't like it much and would prefer
quota code just opencoded these macros. I don't really care but you two
should agree :)

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2015-01-21 22:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 12:47 [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Jan Kara
2015-01-16 12:47 ` [PATCH 01/17] quota: Split ->set_xstate callback into two Jan Kara
2015-01-19  9:00   ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Jan Kara
2015-01-19  9:01   ` Christoph Hellwig
2015-01-20 17:01     ` Jan Kara
2015-01-16 12:47 ` [PATCH 03/17] quota: Add ->quota_{enable, disable} callbacks for VFS quotas Jan Kara
2015-01-19  9:02   ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Christoph Hellwig
2015-01-20 17:08     ` Jan Kara
2015-01-16 12:47 ` [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff Jan Kara
2015-01-19  9:03   ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 05/17] ocfs2: " Jan Kara
2015-01-19  9:03   ` Christoph Hellwig
2015-01-20 17:13     ` Jan Kara
2015-01-16 12:47 ` [PATCH 06/17] quota: Remove quota_on_meta callback Jan Kara
2015-01-19  9:04   ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units Jan Kara
2015-01-19  9:07   ` Christoph Hellwig
2015-01-20 16:53     ` Jan Kara
2015-01-16 12:47 ` [PATCH 08/17] quota: Store maximum space limit in bytes Jan Kara
2015-01-19  9:07   ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing Jan Kara
2015-01-19  9:09   ` Christoph Hellwig
2015-01-20 17:16     ` Jan Kara
2015-01-16 12:47 ` [PATCH 10/17] quota: Make VFS quotas use new interface for getting quota info Jan Kara
2015-01-19  9:10   ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 11/17] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state Jan Kara
2015-01-19  9:11   ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 12/17] xfs: Convert to using ->get_state callback Jan Kara
2015-01-19  9:38   ` Christoph Hellwig
2015-01-20 17:33     ` Jan Kara
2015-01-16 12:47 ` [PATCH 13/17] gfs2: " Jan Kara
2015-01-16 12:47 ` [PATCH 14/17] quota: Remove ->get_xstate and ->get_xstatev callbacks Jan Kara
2015-01-19  9:38   ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 15/17] quota: Make ->set_info use structure with neccesary info to VFS and XFS Jan Kara
2015-01-16 12:47 ` [PATCH 16/17] xfs: Add support for Q_SETINFO Jan Kara
2015-01-16 12:47 ` [PATCH 17/17] quota: Hook up Q_XSETQLIM for id 0 to ->set_info Jan Kara
2015-01-21 21:38 ` [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Dave Chinner
2015-01-21 22:23   ` Jan Kara [this message]
2015-01-21 23:10     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121222320.GA30154@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=cluster-devel@redhat.com \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).