From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [RFC PATCH 4/6] xfs: take i_mmap_lock on extent manipulation operations Date: Fri, 23 Jan 2015 08:32:41 +1100 Message-ID: <20150122213241.GB24722@dastard> References: <1420669543-8093-1-git-send-email-david@fromorbit.com> <1420669543-8093-5-git-send-email-david@fromorbit.com> <20150122132307.GB25345@bfoster.bfoster> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org To: Brian Foster Return-path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:62575 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbbAVVco (ORCPT ); Thu, 22 Jan 2015 16:32:44 -0500 Content-Disposition: inline In-Reply-To: <20150122132307.GB25345@bfoster.bfoster> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jan 22, 2015 at 08:23:08AM -0500, Brian Foster wrote: > On Thu, Jan 08, 2015 at 09:25:41AM +1100, Dave Chinner wrote: > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > index 8be5bb5..f491860 100644 > > --- a/fs/xfs/xfs_iops.c > > +++ b/fs/xfs/xfs_iops.c > > @@ -768,7 +768,7 @@ xfs_setattr_size( > > if (error) > > return error; > > > > - ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL)); > > + ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL|XFS_MMAPLOCK_EXCL)); > > Only debug code of course, but xfs_isilocked() doesn't appear to support > what is intended by this call (e.g., verification of multiple locks). Ah, right. Didn't think that one though properly. I'll fix it up. -Dave. -- Dave Chinner david@fromorbit.com