From: Omar Sandoval <osandov@osandov.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@fb.com>, linux-fsdevel@vger.kernel.org
Subject: Re: [BUG] Oops in inode_to_bdi()
Date: Fri, 23 Jan 2015 17:22:09 -0800 [thread overview]
Message-ID: <20150124012209.GA4893@mew> (raw)
In-Reply-To: <20150121192949.GA24787@infradead.org>
On Wed, Jan 21, 2015 at 11:29:49AM -0800, Christoph Hellwig wrote:
> On Wed, Jan 21, 2015 at 12:17:07PM -0700, Jens Axboe wrote:
> > Christoph,
> >
> > Ran into this one while testing. Looks like mapping->host is NULL, off
> > the shmem_writepage().
>
> Hmm. Not sure how this can happen, but for a NULL inode we can
> always just return noop_backing_dev_info safely, I'll cook up a patch.
Just in case anyone is still wondering, this happens because for a
swapcache page, page_mapping() returns the corresponding address_space
out of swapper_spaces, which doesn't have a valid host pointer. Before
getting rid of backing_dev_info, we would've used swap_backing_dev_info,
which it looks like you replaced with noop_backing_dev_info in your
series, so Jens' fix should be right.
--
Omar
prev parent reply other threads:[~2015-01-24 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 19:17 [BUG] Oops in inode_to_bdi() Jens Axboe
2015-01-21 19:29 ` Christoph Hellwig
2015-01-21 19:33 ` Jens Axboe
2015-01-21 20:04 ` Jens Axboe
2015-01-24 1:22 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150124012209.GA4893@mew \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).