From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonlist@gmail.com>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH-v7 1/3] vfs: add support for a lazytime mount option
Date: Sat, 24 Jan 2015 22:03:52 -0500 [thread overview]
Message-ID: <20150125030352.GB9287@thunk.org> (raw)
In-Reply-To: <87k30ic0lw.fsf@openvz.org>
On Mon, Jan 19, 2015 at 06:21:31PM +0400, Dmitry Monakhov wrote:
> > + if (flags & I_DIRTY_INODE)
> > + flags &= ~I_DIRTY_TIME;
> > + dirtytime = flags & I_DIRTY_TIME;
> TYPO? 'dirtytime' is always false because you have already cleared that bit.
> Probably you want to do that:
> dirtytime = flags & I_DIRTY_TIME;
> if (flags & I_DIRTY_INODE)
> flags &= ~I_DIRTY_TIME;
Nice catch; I screwed that up in the -v7 version of the patch. I've
fixed it in the -v8 version that I just sent out.
- Ted
next prev parent reply other threads:[~2015-01-25 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 4:04 [PATCH-v7 0/3] add support for a lazytime mount option Theodore Ts'o
2014-12-09 4:04 ` [PATCH-v7 1/3] vfs: " Theodore Ts'o
2015-01-19 14:21 ` Dmitry Monakhov
2015-01-25 3:03 ` Theodore Ts'o [this message]
2014-12-09 4:04 ` [PATCH-v7 2/3] vfs: add find_inode_nowait() function Theodore Ts'o
2014-12-09 4:04 ` [PATCH-v7 3/3] ext4: add optimization for the lazytime mount option Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125030352.GB9287@thunk.org \
--to=tytso@mit.edu \
--cc=dmonlist@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).