From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process' Date: Mon, 26 Jan 2015 14:29:44 +0200 Message-ID: <20150126122944.GE25833@node.dhcp.inet.fi> References: <54c1822d.RtdGfWPekQVAw8Ly%akpm@linux-foundation.org> <20150123050445.GA22751@roeck-us.net> <20150123111304.GA5975@node.dhcp.inet.fi> <54C263CC.1060904@roeck-us.net> <20150123135519.9f1061caf875f41f89298d59@linux-foundation.org> <20150124055207.GA8926@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz, "Kirill A. Shutemov" To: Guenter Roeck Return-path: Content-Disposition: inline In-Reply-To: <20150124055207.GA8926@roeck-us.net> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jan 23, 2015 at 09:52:07PM -0800, Guenter Roeck wrote: > On Fri, Jan 23, 2015 at 01:55:19PM -0800, Andrew Morton wrote: > > On Fri, 23 Jan 2015 07:07:56 -0800 Guenter Roeck wrote: > > > > > >> > > > >> qemu:microblaze generates warnings to the console. > > > >> > > > >> WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() > > > >> > > > >> with various call stacks. See > > > >> http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio > > > >> for details. > > > > > > > > Could you try patch below? Completely untested. > > > > > > > >>From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 > > > > From: "Kirill A. Shutemov" > > > > Date: Fri, 23 Jan 2015 13:08:26 +0200 > > > > Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED > > > > > > > > Microblaze uses custom implementation of PMD folding, but doesn't define > > > > __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. > > > > > > > > Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). > > > > It also fixes problems with recently-introduced pmd accounting. > > > > > > > > Signed-off-by: Kirill A. Shutemov > > > > Reported-by: Guenter Roeck > > > > > > Tested working. > > > > > > Tested-by: Guenter Roeck > > > > > > Any idea how to fix the sh problem ? > > > > Can you tell us more about it? All I'm seeing is "qemu:sh fails to > > shut down", which isn't very clear. > > Turns out that the include file defining __PAGETABLE_PMD_FOLDED > was not always included where used, resulting in a messed up mm_struct. What means "messed up" here? It should only affect size of mm_struct. > The patch below fixes the problem for the sh architecture. > No idea if the patch is correct/acceptable for other architectures. That's pain. Some archs includes from . I don't see obvious way to fix this. Urghh. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org