From: Steven Rostedt <rostedt@goodmis.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Finn Thain <fthain@telegraphics.com.au>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-fsdevel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] scsi: Some seq_file cleanups/optimizations
Date: Thu, 29 Jan 2015 09:22:56 -0500 [thread overview]
Message-ID: <20150129092256.1c84193c@gandalf.local.home> (raw)
In-Reply-To: <87wq46aqvz.fsf@rasmusvillemoes.dk>
On Thu, 29 Jan 2015 10:16:16 +0100
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> Steven, you've been doing some cleanup in this area, among other things
> trying to make all the seq_* functions return void. Could you fill me in
> on the status of that?
Yes, the entire seq_*() operations are ambiguous in how they handle
filling the buffers. Don't worry about side effects of using one seq
operation over another (I highly doubt anyone will notice).
I had to stop doing the cleanups to work on other things, but I have
patches to make all seq operations perform the same (and also use the
new seq_buf infrastructure).
And, please ignore any return value from the seq operations. If you
want to know if the buffer is full use seq_has_overflowed() to find out.
I'll try to continue this clean up as a side project.
-- Steve
prev parent reply other threads:[~2015-01-29 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1417221258-4937-1-git-send-email-linux@rasmusvillemoes.dk>
[not found] ` <1417561854-17188-1-git-send-email-linux@rasmusvillemoes.dk>
2015-01-29 6:56 ` [PATCH v2 0/6] scsi: Some seq_file cleanups/optimizations Finn Thain
2015-01-29 9:16 ` Rasmus Villemoes
2015-01-29 14:22 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129092256.1c84193c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=JBottomley@parallels.com \
--cc=fthain@telegraphics.com.au \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).