From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 2/5] fs: saner aio_complete prototype Date: Sat, 31 Jan 2015 10:04:35 +0000 Message-ID: <20150131100435.GO29656@ZenIV.linux.org.uk> References: <1422381313-24034-1-git-send-email-hch@lst.de> <1422381313-24034-3-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Miklos Szeredi , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <1422381313-24034-3-git-send-email-hch@lst.de> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jan 27, 2015 at 06:55:10PM +0100, Christoph Hellwig wrote: > Pass the result as a ssize_t, which is what we use for these returns > all over the kernel. Remove the res2 argument that all relevant > callers always pass as '0'. AFAICS, ->res2 is a part of user-visible ABI and drivers/usb/gadget ones sure as hell don't look like as if it was 0: > - aio_complete(io_data->kiocb, ret, ret); > - aio_complete(iocb, ret, ret); > - aio_complete(iocb, req->actual ? req->actual : req->status, > - req->status); What am I missing here? -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org