From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create
Date: Mon, 2 Feb 2015 15:19:42 +0100
Message-ID: <20150202141942.GA17447@lst.de>
References: <0d8672e771b8fc1fef94db4b40b418afc8763c2b.1422338890.git.osandov@osandov.com> <20150128170952.GB17528@lst.de> <20150202075502.GA24678@mew>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Omar Sandoval <osandov@osandov.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20150202075502.GA24678@mew>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Sun, Feb 01, 2015 at 11:55:02PM -0800, Omar Sandoval wrote:
> There are already a couple of return paths in posix_acl_create, and
> there are only these two error cases, so I think gotos might actually
> make the code more confusing. In any case, here's an idea:
> 
> posix_acl: fix reference leaks in posix_acl_create
> 
> get_acl gets a reference which we must release in the error cases.
> 
> Signed-off-by: Omar Sandoval <osandov@osandov.com>

Thanks, this one looks good to me.

Reviewed-by: Christoph Hellwig <hch@lst.de>