linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: 'Eric Sandeen' <sandeen@sandeen.net>,
	linux-fsdevel@vger.kernel.org,
	'Ashish Sangwan' <a.sangwan@samsung.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_RANGE
Date: Sat, 7 Feb 2015 09:22:27 +1100	[thread overview]
Message-ID: <20150206222227.GN12722@dastard> (raw)
In-Reply-To: <002401d041cf$570eae40$052c0ac0$@samsung.com>

On Fri, Feb 06, 2015 at 02:39:56PM +0900, Namjae Jeon wrote:
> > On 2/5/15 11:10 PM, Namjae Jeon wrote:
> > > Update xfs_io manpage for FALLOC_FL_INSERT_RANGE.
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > > ---
> > >  man/man8/xfs_io.8 | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> > > index cf27b99..416206f 100644
> > > --- a/man/man8/xfs_io.8
> > > +++ b/man/man8/xfs_io.8
> > > @@ -404,6 +404,11 @@ Call fallocate with FALLOC_FL_COLLAPSE_RANGE flag as described in the
> > >  manual page to de-allocates blocks and eliminates the hole created in this process
> > >  by shifting data blocks into the hole.
> > >  .TP
> > > +.BI finsert " offset length"
> > > +Call fallocate with FALLOC_FL_INSERT_RANGE flag as described in the
> > > +.BR fallocate (2)
> > > +manual page
> > 
> Hi Eric,
> > So, it looks like the fallocate(2) manpage will need an update as well.  :)
> Right, I am planning to send the manpage patch for insert range when merging linus tree..

Best to have the man page with the rest of the code changes, that
way they all get reviewed at the same time. :)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2015-02-06 22:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06  5:10 [PATCH] xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_RANGE Namjae Jeon
2015-02-06  5:26 ` Eric Sandeen
2015-02-06  5:39   ` Namjae Jeon
2015-02-06 22:22     ` Dave Chinner [this message]
2015-02-08 23:41       ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150206222227.GN12722@dastard \
    --to=david@fromorbit.com \
    --cc=a.sangwan@samsung.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).