From: Dave Chinner <david@fromorbit.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: tytso@mit.edu, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com, a.sangwan@samsung.com, bfoster@redhat.com,
mtk.manpages@gmail.com, linux-man@vger.kernel.org,
linux-api@vger.kernel.org, Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: [PATCH RESEND 3/12] ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate
Date: Tue, 17 Feb 2015 12:02:20 +1100 [thread overview]
Message-ID: <20150217010220.GH4251@dastard> (raw)
In-Reply-To: <1424101680-3301-4-git-send-email-linkinjeon@gmail.com>
On Tue, Feb 17, 2015 at 12:47:50AM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> This patch implements fallocate's FALLOC_FL_INSERT_RANGE for Ext4.
>
> 1) Make sure that both offset and len are block size aligned.
> 2) Update the i_size of inode by len bytes.
> 3) Compute the file's logical block number against offset. If the computed
> block number is not the starting block of the extent, split the extent
> such that the block number is the starting block of the extent.
> 4) Shift all the extents which are lying bewteen [offset, last allocated extent]
> towards right by len bytes. This step will make a hole of len bytes
> at offset.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
I'll leave this for the ext4 folk to review. If I don't get a review
by the time we're ready to merge the VFS and XFS code, then I'll
leave it out and let Ted merge it inhis own time.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-02-17 1:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 15:47 [PATCH RESEND 0/12] fs: Introduce FALLOC_FL_INSERT_RANGE for fallocate Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 1/12] fs: Add support " Namjae Jeon
2015-02-16 23:53 ` Dave Chinner
2015-02-17 1:49 ` Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 2/12] xfs: " Namjae Jeon
[not found] ` <1424101680-3301-3-git-send-email-linkinjeon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-17 0:54 ` Dave Chinner
2015-02-17 1:47 ` Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 3/12] ext4: " Namjae Jeon
2015-02-17 1:02 ` Dave Chinner [this message]
[not found] ` <1424101680-3301-1-git-send-email-linkinjeon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-16 15:47 ` [PATCH RESEND 4/12] xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_RANGE Namjae Jeon
2015-02-17 0:56 ` Dave Chinner
2015-02-16 15:47 ` [PATCH RESEND 5/12] xfstests: generic/042: Standard insert range tests Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 6/12] xfstests: generic/043: Delayed allocation insert range Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 7/12] xfstests: generic/044: Multi insert range tests Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 8/12] xfstests: generic/045: Delayed allocation multi insert Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 9/12] xfstests: generic/046: Test multiple fallocate insert/collapse range calls Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 10/12] xfstests: fsstress: Add fallocate insert range operation Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 11/12] xfstests: fsx: " Namjae Jeon
2015-02-17 1:00 ` Dave Chinner
2015-02-17 1:43 ` Namjae Jeon
2015-02-16 15:47 ` [PATCH RESEND 12/12] manpage: update FALLOC_FL_INSERT_RANGE flag in fallocate Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217010220.GH4251@dastard \
--to=david@fromorbit.com \
--cc=a.sangwan@samsung.com \
--cc=bfoster@redhat.com \
--cc=linkinjeon@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=namjae.jeon@samsung.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).