From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state
 callback
Date: Wed, 18 Feb 2015 08:51:54 -0800
Message-ID: <20150218165154.GA29465@infradead.org>
References: <1424267274-11836-1-git-send-email-jack@suse.cz>
 <1424267274-11836-4-git-send-email-jack@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
	xfs@oss.sgi.com
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.9]:48143 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751562AbbBRQvy (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 18 Feb 2015 11:51:54 -0500
Content-Disposition: inline
In-Reply-To: <1424267274-11836-4-git-send-email-jack@suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> +static void
> +xfs_qm_fill_state(
> +	struct qc_type_state *tstate,
> +	struct xfs_mount *mp,
> +	struct xfs_inode *ip,
> +	xfs_ino_t ino)

> +/*
> + * Return quota status information, such as enforcements, quota file inode
> + * numbers etc.
> + */
> +static int
> +xfs_fs_get_quota_state(
> +	struct super_block *sb,
> +	struct qc_state *state)

We usually tab-align the arguments in XFS prototypes.


Otherwise this patch looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>