From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callback Date: Wed, 18 Feb 2015 18:11:38 +0100 Message-ID: <20150218171138.GA11951@quack.suse.cz> References: <1424267274-11836-1-git-send-email-jack@suse.cz> <1424267274-11836-4-git-send-email-jack@suse.cz> <20150218165154.GA29465@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, xfs@oss.sgi.com To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:51834 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753614AbbBRRLq (ORCPT ); Wed, 18 Feb 2015 12:11:46 -0500 Content-Disposition: inline In-Reply-To: <20150218165154.GA29465@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 18-02-15 08:51:54, Christoph Hellwig wrote: > > +static void > > +xfs_qm_fill_state( > > + struct qc_type_state *tstate, > > + struct xfs_mount *mp, > > + struct xfs_inode *ip, > > + xfs_ino_t ino) > > > +/* > > + * Return quota status information, such as enforcements, quota file inode > > + * numbers etc. > > + */ > > +static int > > +xfs_fs_get_quota_state( > > + struct super_block *sb, > > + struct qc_state *state) > > We usually tab-align the arguments in XFS prototypes. OK, fixed. > Otherwise this patch looks good, > > Reviewed-by: Christoph Hellwig Thanks. Honza -- Jan Kara SUSE Labs, CR