From: Christoph Hellwig <hch@infradead.org>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Michal Nazarewicz <mina86@mina86.com>,
Felipe Balbi <balbi@ti.com>,
linux-fsdevel@vger.kernel.org
Subject: commit "usb: gadget: ffs: add eventfd notification about ffs events"
Date: Wed, 18 Feb 2015 09:36:39 -0800 [thread overview]
Message-ID: <20150218173639.GA18641@infradead.org> (raw)
Hi Robert,
your above commit pokes into kiocb internals it really should not, and
it breaks my patchset that's been on the -fsdevel list which makes most
of the kiocb guts private to fs/aio.c.
First please Cc patches like that to linux-fsdevel. Second I don't
think the logic in it is correct. You should not disable your own
notifications based on how aio works, but do it unconditionally. What
was the reason to disable the eventfd notification if there is an aio
one as well?
next reply other threads:[~2015-02-18 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 17:36 Christoph Hellwig [this message]
2015-02-19 6:35 ` commit "usb: gadget: ffs: add eventfd notification about ffs events" Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218173639.GA18641@infradead.org \
--to=hch@infradead.org \
--cc=balbi@ti.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=r.baldyga@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).