From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: commit "usb: gadget: ffs: add eventfd notification about ffs events" Date: Wed, 18 Feb 2015 09:36:39 -0800 Message-ID: <20150218173639.GA18641@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , Michal Nazarewicz , Felipe Balbi , linux-fsdevel@vger.kernel.org To: Robert Baldyga Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:52814 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753782AbbBRRgu (ORCPT ); Wed, 18 Feb 2015 12:36:50 -0500 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Robert, your above commit pokes into kiocb internals it really should not, and it breaks my patchset that's been on the -fsdevel list which makes most of the kiocb guts private to fs/aio.c. First please Cc patches like that to linux-fsdevel. Second I don't think the logic in it is correct. You should not disable your own notifications based on how aio works, but do it unconditionally. What was the reason to disable the eventfd notification if there is an aio one as well?