From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] more vfs bits
Date: Sun, 22 Feb 2015 02:11:57 +0000 [thread overview]
Message-ID: <20150222021156.GB29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150222020207.GA29656@ZenIV.linux.org.uk>
On Sun, Feb 22, 2015 at 02:02:07AM +0000, Al Viro wrote:
> Hmm... ..._once() variants are trivially dropped, IMO. dentry_inode_once()
> is so bloody special that it *SHOULD* stick out; we don't have any places
> like that, anyway.
>
> I'm somewhat tempted to do this:
> fs_inode -> d_inode
> fs_inode_once ->d_inode_rcu (it's not quite ->d_revalidate()-only, there's
> a bit in autofs ->d_manage() as well)
> dentry_inode -> something. d_opened_inode() might do, but I'm not sure -
> still sounds a bit wrong to me. What it's about is "the actual fs object
> behind this name, maybe from upper fs, maybe showing through from underlying
> layer". It's not always opened; it's what we'd get if we opened it (and
> hadn't triggered any copyups, that is). E.g. sys_getxattr() would want to
> use that, even if nobody has opened that sucker yet, etc.
*snort*
d_inode/d_inode_rcu/[d_]inode_here(), perhaps? ;-)
next prev parent reply other threads:[~2015-02-22 2:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 3:34 [git pull] more vfs bits Al Viro
2015-02-21 22:45 ` Linus Torvalds
2015-02-21 22:48 ` Linus Torvalds
2015-02-22 0:23 ` David Howells
2015-02-22 0:59 ` Al Viro
2015-02-22 0:51 ` Al Viro
2015-02-22 1:34 ` Linus Torvalds
2015-02-22 2:02 ` Al Viro
2015-02-22 2:11 ` Al Viro [this message]
2015-02-22 2:19 ` Linus Torvalds
2015-02-22 2:51 ` Al Viro
2015-02-22 3:16 ` Linus Torvalds
2015-02-22 8:51 ` Al Viro
2015-02-22 9:32 ` Sedat Dilek
2015-02-22 9:37 ` Al Viro
2015-02-22 10:36 ` Sedat Dilek
2015-02-22 15:05 ` Sedat Dilek
2015-02-22 15:12 ` Sedat Dilek
2015-02-22 13:22 ` Sedat Dilek
2015-02-22 13:23 ` Sedat Dilek
2015-02-22 12:54 ` David Howells
2015-02-22 16:46 ` [git pull] more vfs bits, updated Al Viro
2015-02-22 20:10 ` Sedat Dilek
2015-02-22 12:44 ` [git pull] more vfs bits David Howells
2015-02-22 12:39 ` David Howells
2015-02-22 12:30 ` David Howells
2015-02-22 0:18 ` David Howells
2015-02-22 1:14 ` Linus Torvalds
2015-02-22 1:32 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2013-03-03 16:04 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150222021156.GB29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).