From: Guenter Roeck <linux@roeck-us.net>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-sh@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>
Subject: Re: fs: dax: do not build on ARC or SH
Date: Mon, 23 Feb 2015 13:56:34 -0800 [thread overview]
Message-ID: <20150223215634.GA23928@roeck-us.net> (raw)
In-Reply-To: <20150223184025.GD2780@wil.cx>
On Mon, Feb 23, 2015 at 01:40:25PM -0500, Matthew Wilcox wrote:
> On Mon, Feb 23, 2015 at 12:29:45PM +0100, Arnd Bergmann wrote:
> > The DAX implementation relies on the architecture to provide a working
> > copy_user_page() function, as reported by Michael Ellerman's kisskb
> > build bot:
> >
> > fs/dax.c: error: implicit declaration of function 'copy_user_page' [-Werror=implicit-function-declaration]: => 266:2
> >
> > We already have a list of architectures that are known to be incompatible,
> > but the list is missing ARC and SH at the moment. Further, blackfin and
> > c6x also lack support for this function, but are already excluded because
> > they do not support MMU-based kernels.
>
> I've got a short list of patches for DAX; I'll add this one to the list.
>
> Have the maintainers of these architectures been notified that they're
> missing a core piece of kernel functionality?
>
Guess there a philosophical difference in opinion if the architecture code
should (have to) provide copy_user_page() or not outside the architecture
code itself. After all, fs/dax.c _is_ the only user of this function outside
the architecture code.
Guenter
next prev parent reply other threads:[~2015-02-23 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 11:29 fs: dax: do not build on ARC or SH Arnd Bergmann
2015-02-23 18:40 ` Matthew Wilcox
2015-02-23 21:31 ` Arnd Bergmann
2015-02-23 21:56 ` Guenter Roeck [this message]
2015-02-23 21:58 ` Christoph Hellwig
2015-02-23 22:15 ` Guenter Roeck
2015-02-28 0:59 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223215634.GA23928@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=vgupta@synopsys.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).